ThePortForumRed update

Make suggestions and report problems.
Post Reply
User avatar
jdaw1
Cockburn 1851
Posts: 23613
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

ThePortForumRed update

Post by jdaw1 »

Since August 2008 ThePortForum has used a custom phpBB style with a series of names beginning with ThePortForumRed.

Each of its iterations has been made by taking a new copy of the default phpBB style, prosilver, and altering that. This process is high maintenance: changes in prosilver cause a complete rewrite of ThePortForumRed. Yes, the rewrite is done with much copy-paste, but still, it is a pain.

Something called Template Inheritance allows one style to be a ‘child’ of another. That is, the child style specifies only the things that have changed, inheriting everything else. So if a new version of the parent style has new features or complexities, they would automatically be inherited by the child style. This would be more robust and much more durable, and hence less work.

It is planned to rewrite ThePortForumRed as a child of prosilver.

I am not planning any major changes that would be visible to users. But requests (please, neither silly nor facetious) might be entertained. Ask here, soon.
User avatar
benread
Niepoort 1977
Posts: 1555
Joined: 21:36 Thu 17 Apr 2008
Location: Reigate, Surrey
Contact:

Re: ThePortForumRed update

Post by benread »

I have one suggestion - it relates to what might be considered the home page when using a web browser rather than the App. I expect a click on any website logo to take me 'home'. With TPF, it takes me to 'Unread posts' rather than index.php. Is that intended? Am I the only one who would prefer the Index page?
Ben
-------
Vintage 1970 and now proud owner of my first ever 'half-century'!
User avatar
JacobH
Quinta do Vesuvio 1994
Posts: 3300
Joined: 16:37 Sat 03 May 2008
Location: London, UK
Contact:

Re: ThePortForumRed update

Post by JacobH »

benread wrote: 11:17 Sun 07 Nov 2021 I have one suggestion - it relates to what might be considered the home page when using a web browser rather than the App. I expect a click on any website logo to take me 'home'. With TPF, it takes me to 'Unread posts' rather than index.php. Is that intended? Am I the only one who would prefer the Index page?
I agree. I would expect (and prefer) it to be the index page. That’s mostly because I don’t find the phpBB “unread posts” very helpful.

I’m not sure if the smilies are a separate process, but if not, could we have a couple of bottles? You are welcome to use my full-sized and half-bottle icons if they are usable.

75cl:
bottle.png
bottle.png (299 Bytes) Viewed 5765 times
Half:
half.png
half.png (265 Bytes) Viewed 5765 times
Finally, I am not sure if this a feature of my setup or something other people are noticing, but a few font sizes seem a touch on the small size. For example, in a forum view, the page numbers when a thread has multiple pagers at 9px. I think it looks a lot clearer at 10px. Also the index page seems to have a bit more whitespace than the previous version around each forum’s details. I wonder if the title of each forum could be nudged just a little bit up? But these are very small points. I am otherwise very happy with the look of ThePortForumRed.
Image
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: ThePortForumRed update

Post by DRT »

I seem to recall that a previous upgrade resulted in the "Unread posts" link disappearing from its previous default place in the phpBB software. Someone, perhaps more than one, requested that it be put back where it was. We found a workaround by having "Unread posts" as the default link that is attached to the logo in the board settings (nothing to do with the style). It can easily be changed back but would result in the loss of the unread posts link being where it is now.
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
JacobH
Quinta do Vesuvio 1994
Posts: 3300
Joined: 16:37 Sat 03 May 2008
Location: London, UK
Contact:

Re: ThePortForumRed update

Post by JacobH »

DRT wrote: 19:09 Mon 08 Nov 2021 I seem to recall that a previous upgrade resulted in the "Unread posts" link disappearing from its previous default place in the phpBB software. Someone, perhaps more than one, requested that it be put back where it was. We found a workaround by having "Unread posts" as the default link that is attached to the logo in the board settings (nothing to do with the style). It can easily be changed back but would result in the loss of the unread posts link being where it is now.
Ah, yes. I think I remember that. Looks like phpBB have sorted that out.
Image
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: ThePortForumRed update

Post by DRT »

JacobH wrote: 13:45 Wed 10 Nov 2021
DRT wrote: 19:09 Mon 08 Nov 2021 I seem to recall that a previous upgrade resulted in the "Unread posts" link disappearing from its previous default place in the phpBB software. Someone, perhaps more than one, requested that it be put back where it was. We found a workaround by having "Unread posts" as the default link that is attached to the logo in the board settings (nothing to do with the style). It can easily be changed back but would result in the loss of the unread posts link being where it is now.
Ah, yes. I think I remember that. Looks like phpBB have sorted that out.
What do you mean by "have sorted that out"?
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
JacobH
Quinta do Vesuvio 1994
Posts: 3300
Joined: 16:37 Sat 03 May 2008
Location: London, UK
Contact:

Re: ThePortForumRed update

Post by JacobH »

Sorted out the disappearing link: the "Unread Posts" link seems to be showing on every page for me whether I am logged in or not.Image
Image
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: ThePortForumRed update

Post by DRT »

DRT wrote: 19:09 Mon 08 Nov 2021 I seem to recall that a previous upgrade resulted in the "Unread posts" link disappearing from its previous default place in the phpBB software. Someone, perhaps more than one, requested that it be put back where it was. We found a workaround by having "Unread posts" as the default link that is attached to the logo in the board settings (nothing to do with the style). It can easily be changed back but would result in the loss of the unread posts link being where it is now.
To explain this further...
Screenshot 2021-11-10 at 21.45.01.png
Screenshot 2021-11-10 at 21.45.01.png (41.48 KiB) Viewed 5713 times
The picture above is the current left hand corner of the screen I see in my browser. The logo in the top left and the link "Unread Posts" at the start of the breadcrumbs are both controlled by one entry in the board settings. That setting allows you to specify a url that each of those elements will take you to if you click on them. You can't choose a different url for each element. By default they both point to the main forum page, but we set the url to be the unread posts page to compensate for phpBB taking the previous link away. A second setting allows us to set the text for the root link in the breadcrumbs, which would normally default to "Home". We set that to "Unread Posts" so that is describes where the link will take you.
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
JacobH
Quinta do Vesuvio 1994
Posts: 3300
Joined: 16:37 Sat 03 May 2008
Location: London, UK
Contact:

Re: ThePortForumRed update

Post by JacobH »

Ah. I'm really sorry - I remembered the discussion but thought only the logo's link had been set as a workaround and that the "unread posts" link was the default.
Image
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: ThePortForumRed update

Post by DRT »

JacobH wrote: 22:54 Wed 10 Nov 2021 Ah. I'm really sorry - I remembered the discussion but thought only the logo's link had been set as a workaround and that the "unread posts" link was the default.
Don't be sorry, just be confused like we were before we worked out how to get around the feature disappearing :lol:
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: ThePortForumRed update

Post by DRT »

This might help...
.
.
Screenshot 2021-11-10 at 21.54.10.png
Screenshot 2021-11-10 at 21.54.10.png (82.23 KiB) Viewed 5710 times
"The first duty of Port is to be red"
Ernest H. Cockburn
Andy Velebil
Quinta do Vesuvio 1994
Posts: 3028
Joined: 22:16 Mon 25 Jun 2007
Location: Los Angeles, Ca USA
Contact:

Re: ThePortForumRed update

Post by Andy Velebil »

Is there any way for a user to change the red to something else? That much red really bothers my eyes trying to read it.
PhilW
Dalva Golden White Colheita 1952
Posts: 3503
Joined: 14:22 Wed 15 Dec 2010
Location: Near Cambridge, UK

Re: ThePortForumRed update

Post by PhilW »

Andy Velebil wrote: 02:45 Thu 11 Nov 2021 Is there any way for a user to change the red to something else? That much red really bothers my eyes trying to read it.
I was going to suggest that you can always choose to use the original phpbb default "Prosilver" style rather than ThePortForumRed, except I just looked in the user control panel and can't see where we could choose from the available styles.
Derek - is per-user style choice still intended to be available, and if so can someone point me at where we can select it, or do we need to fix something?
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: ThePortForumRed update

Post by DRT »

I used a feature in the admin control panel to migrate everyone to the new default style PortForumRed2021_11. This includes an override of any other style selected by the user (such as prosilver), which is why Andy has been seeing red. I have now removed the override so Andy and a few others should now see the blue prosilver style.
"The first duty of Port is to be red"
Ernest H. Cockburn
Andy Velebil
Quinta do Vesuvio 1994
Posts: 3028
Joined: 22:16 Mon 25 Jun 2007
Location: Los Angeles, Ca USA
Contact:

Re: ThePortForumRed update

Post by Andy Velebil »

DRT wrote: 09:58 Thu 11 Nov 2021 I used a feature in the admin control panel to migrate everyone to the new default style PortForumRed2021_11. This includes an override of any other style selected by the user (such as prosilver), which is why Andy has been seeing red. I have now removed the override so Andy and a few others should now see the blue prosilver style.
My eyes are now very happy. Thank you!
PhilW
Dalva Golden White Colheita 1952
Posts: 3503
Joined: 14:22 Wed 15 Dec 2010
Location: Near Cambridge, UK

Re: ThePortForumRed update

Post by PhilW »

Only noted today, but the "online" flash across the corner of the user's icon if they are online while you are browsing the forum is currently a little "out if place" to my eye colour-wise since blues when should be red/pinks. Maybe worth a minor mod if easy. (nb alternative option of disabling the flashes if not wanted/liked)
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: ThePortForumRed update

Post by DRT »

The latest version of the :tpf: style is now live. Please report any issues in this thread.

Thanks go to jdaw1 for creating the new version.
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: ThePortForumRed update

Post by DRT »

A big gap has appeared between the site logo and the header text.
Screenshot 2021-11-16 at 18.25.51.png
Screenshot 2021-11-16 at 18.25.51.png (42.4 KiB) Viewed 5622 times
Viewed on a MacBook running macOS Big Sur 11.6 in Safari 14.1.2.
"The first duty of Port is to be red"
Ernest H. Cockburn
PhilW
Dalva Golden White Colheita 1952
Posts: 3503
Joined: 14:22 Wed 15 Dec 2010
Location: Near Cambridge, UK

Re: ThePortForumRed update

Post by PhilW »

Same here on chrome on Android as desktop view. It looks as though that cell may be centred, rather then left adjusted.
User avatar
jdaw1
Cockburn 1851
Posts: 23613
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: ThePortForumRed update

Post by jdaw1 »

DRT wrote: 19:28 Tue 16 Nov 2021A big gap has appeared between the site logo and the header text.

Screenshot 2021-11-16 at 18.25.51.png

Viewed on a MacBook running macOS Big Sur 11.6 in Safari 14.1.2.
Believed fixed.
User avatar
jdaw1
Cockburn 1851
Posts: 23613
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: ThePortForumRed update

Post by jdaw1 »

Decisions:

It was proposed that we make use of inheritance. Yes, except that the one thing not inherited is the CSS, which is most of our changes.

Hence rejected.



It was proposed that colours be put in variables, for ease of later changing. Rejected, because prosilver will soon die. Phpbb 4.* will have a new base style, Chameleon:
this is not just a change in the design and a simple code refactor. We are overhauling the entire way that themes will work in the next major version in order to streamline both the development of the software and make it easier on the theme designers and end-users to make simple customization. To do this one major change is the use of a build step for the theme.
So the sensible time to rebuild TPF Red completely is for phpbb 4. Hopefully — yes, I know — the working of styles will make it easier to change only icons and colours. But that is a problem for later.
Post Reply