New Style

Make suggestions and report problems.
User avatar
JacobH
Quinta do Vesuvio 1994
Posts: 3300
Joined: 16:37 Sat 03 May 2008
Location: London, UK
Contact:

Re: New Style

Post by JacobH »

jdaw1 wrote:JacobH: “slightly more restrained use of px as a unit of measurement†. Yes and no. The logo is a fixed 48px by 48px, so H1 text shown next to that should be expressed in px. For sensible comparison, so is H2. My intention was that other text be in ems, though PEBKAC is more than likely.
At the moment, you’ve got h1 as 4ems which on my machine, with default settings, translates to about 62px:

Code: Select all

/* Site description and logo */
#site-description {
	float: left;
	width: 70%;
	font-size: 4em;
[…]
}
The h2 is, however, being explicitly defined as 48px

Code: Select all

h2 {
	/* Forum header titles */
	font-family: "Trebuchet MS", Arial, Helvetica, sans-serif;
	font-weight: normal;
	color: #3f3f3f;
	font-size: 48px;
	margin: 0.8em 0 0.2em 0;
}
Perhaps we could have the h2.logo being 48px and have the normal h2 (which is used as the topic titles) slightly smaller?

Incidentally, if ProSilver is the default style for phpbb3, I’m a bit appalled at the quality of the CSS that they’ve put into the release. Due to the Cascading nature of CSS, having a well structured file is absolutely vital. Also, if grouping is done properly and by feature rather than html element, it is much easier to modify the CSS without running hundreds of search/replace queries. You very much have my sympathy for having to wrestle with it!
Image
User avatar
JacobH
Quinta do Vesuvio 1994
Posts: 3300
Joined: 16:37 Sat 03 May 2008
Location: London, UK
Contact:

Re: New Style

Post by JacobH »

DRT wrote:
JacobH wrote: I hate to think how much of my life I have wasted
I am prepared to sympathyse providing the waste is expressed as a percentage of current age :wink:
At a conservative estimate of 6 months, I suppose that would be something like 5%? ;-)
Image
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

jabobH wrote:I’m a bit appalled at the quality of the CSS that they’ve put into the release. Due to the Cascading nature of CSS, having a well structured file is absolutely vital
Thank you — it’s not just me. It does seem like a mess.

Anyway, you have email with the latest version. Feel free to rewrite (or to tell me to rewrite) anything.
User avatar
benread
Niepoort 1977
Posts: 1555
Joined: 21:36 Thu 17 Apr 2008
Location: Reigate, Surrey
Contact:

Re: New Style

Post by benread »

Am I being blind or is the "quote" button now awol?
Ben
-------
Vintage 1970 and now proud owner of my first ever 'half-century'!
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: New Style

Post by DRT »

JacobH wrote:
DRT wrote:
JacobH wrote: I hate to think how much of my life I have wasted
I am prepared to sympathyse providing the waste is expressed as a percentage of current age :wink:
At a conservative estimate of 6 months, I suppose that would be something like 5%?
So, you can think yourself lucky that you are not my age otherwise that would be 53 months :wink:
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: New Style

Post by DRT »

jdaw1 wrote: Good spot. Found and fixed, at least on my at-home version.
Jdaw1,

I'm not sure what your "at home" version consists of but if it allows you to seem the results of your labour when applying fixes then perhaps you could post screenshots here so that we can continue to comment between updates to the live system?

Derek
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

I have set the default style back to black.

Users may still choose ThePortForumRed for themselves, if they should so wish. When it’s nearer perfection it will become the default.
User avatar
RonnieRoots
Fonseca 1980
Posts: 1981
Joined: 08:28 Thu 21 Jun 2007
Location: Middle Earth

Re: New Style

Post by RonnieRoots »

jdaw1 wrote:I have set the default style back to black.

Users may still choose ThePortForumRed for themselves, if they should so wish. When it’s nearer perfection it will become the default.
Will this style still be available when theportforumred becomes default?
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

RonnieRoots wrote:Will this style still be available when theportforumred becomes default?
Chief Admin’s decision.
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: New Style

Post by DRT »

jdaw1 wrote:
RonnieRoots wrote:Will this style still be available when theportforumred becomes default?
Chief Admin’s decision.
I agree it is Chief Admin's decision but I vote yes, it should still be available for the users to choose individually if they want to.
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

Larger icons implemented. Comment welcome.

New colours can’t yet be enabled because of a strange bug that will, hopefully, be fixed soon.
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: New Style

Post by DRT »

The button size does not seem to have changed. Perhaps the change just isn't great enough to make a difference.

I have noticed that a few of the buttons (such as Reply) seem to have hyperlinks hidded beneath them that are not very well hidded.

Derek
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

DRT wrote:I have noticed that a few of the buttons (such as Reply) seem to have hyperlinks hidded beneath them that are not very well hidded.
Hmm. Will work on that. (Except that none of my work will have any affect until the ‘refresh’ problem is fixed.)
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

Hmmmm. Refresh problem was my fault: strictly ASCII please — no “•† characters.

So we have progress — please set your style to ThePortForumRed, and either marvel or make specific suggestions.

And I know the jump-to-top graphic is a mess.

And please, in the following why doesn’t the second set of lines work?

Code: Select all

a:link:focus, a:visited:focus {border: thin dotted #cc9933;}
a:link {color: #990000;}
a:visited {color: #cc9933;}
a:link:hover, a:visited:hover {color: #000000;}
a:link:active, a:visited:active {color: #ffffff; background-color: #990000;} 

a:link[background-color ~= #990000] {color: #ffffff;}
a:link:hover[background-color ~= #990000] {color: #c46a6a;}
a:visited:hover[background-color ~= #990000] {color: #c46a6a;}
a:link:active[background-color ~= #990000] {color: #990000; background-color: #cc9933;} 
a:visited:active[background-color ~= #990000] {color: #990000; background-color: #cc9933;}
User avatar
benread
Niepoort 1977
Posts: 1555
Joined: 21:36 Thu 17 Apr 2008
Location: Reigate, Surrey
Contact:

Re: New Style

Post by benread »

I have moved to new TPF red style and "back to the top" buttons seem to be missing. Any ideas how I get these back?

Thanks.
Ben
-------
Vintage 1970 and now proud owner of my first ever 'half-century'!
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

benread wrote:Any ideas how I get these back?
You ask me. On the case.
User avatar
JacobH
Quinta do Vesuvio 1994
Posts: 3300
Joined: 16:37 Sat 03 May 2008
Location: London, UK
Contact:

Re: New Style

Post by JacobH »

jdaw1 wrote:Hmmmm. Refresh problem was my fault: strictly ASCII please — no “•† characters.
Ah, that’s what those characters were! Out of interest, what encoding were you using? I would have thought UTF-8 would be safe.

The new theme is great; I like it a lot and anyone on ProSilver should switch. I do wonder whether the header might change, though. To my eyes, it might look better if either the logo (or, if not the whole logo, just the letters) were re-drawn so it appeared smooth at a larger size, or if the header appeared in a mono-spaced typeface which would then more closely match the letters of the logo.
jdaw1 wrote: And please, in the following why doesn’t the second set of lines work?

Code: Select all

a:link:focus, a:visited:focus {border: thin dotted #cc9933;}
a:link {color: #990000;}
a:visited {color: #cc9933;}
a:link:hover, a:visited:hover {color: #000000;}
a:link:active, a:visited:active {color: #ffffff; background-color: #990000;} 

a:link[background-color ~= #990000] {color: #ffffff;}
a:link:hover[background-color ~= #990000] {color: #c46a6a;}
a:visited:hover[background-color ~= #990000] {color: #c46a6a;}
a:link:active[background-color ~= #990000] {color: #990000; background-color: #cc9933;} 
a:visited:active[background-color ~= #990000] {color: #990000; background-color: #cc9933;}
I think you may have got this working, but if not:

CSS defines 4 main link pseudo-elements:
a:link (normal link)
a:visited (link that has already been visited)
a:hover (normal link with mouseover)
a:active (link that has been clicked on and is currently loading)

They must, bizarrely, come in that order to work and I don’t believe that you are able to nest them (so you can’t have a different colour for a visited link which has been hovered over compared to one that has not been visited and is being hovered over; but I don’t think you are trying to do that).

-Jacob
Image
User avatar
JacobH
Quinta do Vesuvio 1994
Posts: 3300
Joined: 16:37 Sat 03 May 2008
Location: London, UK
Contact:

Re: New Style

Post by JacobH »

jdaw1 wrote: And please, in the following why doesn’t the second set of lines work?

Code: Select all

a:link:focus, a:visited:focus {border: thin dotted #cc9933;}
a:link {color: #990000;}
a:visited {color: #cc9933;}
a:link:hover, a:visited:hover {color: #000000;}
a:link:active, a:visited:active {color: #ffffff; background-color: #990000;} 

a:link[background-color ~= #990000] {color: #ffffff;}
a:link:hover[background-color ~= #990000] {color: #c46a6a;}
a:visited:hover[background-color ~= #990000] {color: #c46a6a;}
a:link:active[background-color ~= #990000] {color: #990000; background-color: #cc9933;} 
a:visited:active[background-color ~= #990000] {color: #990000; background-color: #cc9933;}
Also, I haven’t used attribute selectors before, but can they be used for CSS? I thought they could only be used for selecting HTML attributes? For example:
input[type="submit"]{ xyz };
would select:
<input type="submit">

The only way to achieve CSS selection would with be with in-line CSS:
p[style="color: white"]{ xyz };
or a class:
p[class="post"]{ xyz };
Image
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

JacobH wrote:The new theme is great; I like it a lot and anyone on ProSilver should switch.
Well, thank you kindly.
JacobH wrote:I do wonder whether the header might change, though. To my eyes, it might look better if either the logo (or, if not the whole logo, just the letters) were re-drawn so it appeared smooth at a larger size, or if the header appeared in a mono-spaced typeface which would then more closely match the letters of the logo.
This is a digital community: its digitality, the forum, is at its core. Hence the deliberately bitmapped logo. The official TPF typeface is Palatino Bold, and the official colour is 0.6:0:0 = 990000, or pantone 704 in print.

As for the CSS, www.webmasterworld.com/forum83/9334.htm suggested the layout I used. (And I am thoroughly unable to adjudicate its disagreement with you.) But in any event the problem was ‘fixed’ only by removing all the 990000 backgrounds.
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

jdaw1 wrote:
benread wrote:Any ideas how I get these back?
You ask me. On the case.
BackToTop uparrow has returned. That was more trouble, and less well done, than it ought to have been.

Private message pages also tidied. Comment welcomed.
User avatar
benread
Niepoort 1977
Posts: 1555
Joined: 21:36 Thu 17 Apr 2008
Location: Reigate, Surrey
Contact:

Re: New Style

Post by benread »

jdaw1 wrote:
jdaw1 wrote:
benread wrote:Any ideas how I get these back?
You ask me. On the case.
BackToTop uparrow has returned. That was more trouble, and less well done, than it ought to have been.

Private message pages also tidied. Comment welcomed.
...but much appreciated. Thank you.
Ben
-------
Vintage 1970 and now proud owner of my first ever 'half-century'!
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: New Style

Post by DRT »

Could the header please look like this?

Note smaller font.

Image

ThePortForum.com
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

No. That occupies more vertical space — one would have to scroll sooner and further.
User avatar
DRT
Fonseca 1966
Posts: 15779
Joined: 23:51 Wed 20 Jun 2007
Location: Chesterfield, UK
Contact:

Re: New Style

Post by DRT »

Can we have the smaller font and a larger gap between the logo and ThePortForum.com?



ImageThePortForum.com
"The first duty of Port is to be red"
Ernest H. Cockburn
User avatar
jdaw1
Cockburn 1851
Posts: 23719
Joined: 15:03 Thu 21 Jun 2007
Location: London
Contact:

Re: New Style

Post by jdaw1 »

Screenshot very helpful. Thank you. Looks far better on my Mac Firefox.

Please could you ensure that the stylesheets are refreshed. Please click refresh, shift-refresh, or whatever it is on IE that forces it to completely reload.
Post Reply